Avoid calling tag enumerator block if lookup returns nil tag #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the tag enumerator block can be called with a nil GTTag, leading to an exception when allTagsWithError adds it to tagArray.
| @@ -457,7 +457,9 @@ static int GTRepositoryForeachTagCallback(const char *name, git_oid *oid, void * | |||
| GTTag *tag = (GTTag *)[info->myself lookUpObjectByGitOid:oid objectType:GTObjectTypeTag error:NULL]; | |||
|
|
|||
| BOOL stop = NO; | |||
| info->block(tag, &stop); | |||
| if (tag) { | |||
There was a problem hiding this comment.
Style: do an explicit comparison != nil
|
Thanks! Just one note. |
|
Fixed, thanks for the tip. |
|
💥 |
joshaber
added a commit
that referenced
this pull request
Jun 2, 2015
Avoid calling tag enumerator block if lookup returns nil tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag lookup may fail in
GTRepositoryForeachTagCallback, resulting in a nil value fortag. This change skips the block iftagis nil.Otherwise, a nil tag may be passed to the block. In the case of
allTagsWithError:, the nil is added to an array, causing an exception or crash.